Changes approach for setting the required tabs from URL parameters #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This discard use of '' for finding available tabs because of an issue with asynchronous loading of the dataset component and its subcomponents, which include tabs that might or might not be defined at the time when 'created()' or 'mounted()' is called in the vue app life cycle. This issue has in the past resulted in erratic tab selection. Instead, the new method determines the available tabs from the root component data, and accesses this list both on 'created()' and on 'beforeRouteUpdate()' to check the provided URL parameter against.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 43 43
Lines 2709 2709
=======================================
Hits 2335 2335
Misses 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
A sneaky but very small addition to the PR is: 922fc67 In response to: sfb1451/metadata-catalog#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to: sfb1451/metadata-catalog#33, which exists as a result of a regression introduced in d25dcd2
This issue has in the past resulted in erratic tab selection, and it relates to a number of previous issues:
The new update discards the use of
$refsfor finding available tabs because of an issue with asynchronous loading of$root, the dataset component and its subcomponents, and$refs. It can happen that$refsmight or might not be defined at the time whencreated()ormounted()is called in the vue app life cycle. For a more useful description, see https://stackoverflow.com/questions/54355375/vue-js-refs-are-undefined-even-though-this-refs-shows-theyre-there.Instead, the new method determines the available tabs from the root component data, and accesses this list both on 'created()' and on 'beforeRouteUpdate()' in order to check the provided URL parameter against this list.